Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce eol-last rule #32335

Merged
merged 2 commits into from
Nov 29, 2024
Merged

chore: enforce eol-last rule #32335

merged 2 commits into from
Nov 29, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 29, 2024 •
edited
Loading

Reason for this change

This rule was previously not enforced and implementation inconsistent.
Enforcing a new line at the end of the file makes it easier to append files.

Description of changes

No code changes! Only formatting. 💅🏻

And a bit of config:

  • Added a new eslint rule for eol-last
  • Added a VSCode seting to automatically insert newlines
  • Applied the rule to all non-compliant files

Best reviewed with whitespace changes ignored: https://github.com/aws/aws-cdk/pull/32335/files?w=1

Description of how you validated changes

No code changes, purely formatting.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner November 29, 2024 18:04
@github-actions github-actions bot added the p2 label Nov 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2024 18:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 29, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 29, 2024
@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Nov 29, 2024
@mrgrain
Copy link
Contributor Author

mrgrain commented Nov 29, 2024

Applied pr-linter/cli-integ-tested to pass the linter, but didn't run the tests because there is not need to run them since the PR only contains whitespace changes.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 29, 2024 18:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 29, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/eol-last branch from bcb2554 to 548db5a Compare November 29, 2024 18:49
@mrgrain mrgrain force-pushed the mrgrain/chore/eol-last branch from 548db5a to 3d422bb Compare November 29, 2024 19:19
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (dc7574a) to head (1abd85c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32335      +/-   ##
==========================================
- Coverage   78.46%   78.42%   -0.05%     
==========================================
  Files         106      106              
  Lines        7208     7208              
  Branches     1323     1323              
==========================================
- Hits         5656     5653       -3     
- Misses       1364     1368       +4     
+ Partials      188      187       -1
Flag Coverage Δ
suite.unit 78.42% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.42% <ø> (-0.05%) ⬇️

@mrgrain mrgrain force-pushed the mrgrain/chore/eol-last branch from 316b5ca to 1abd85c Compare November 29, 2024 20:25
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1abd85c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain merged commit 81cde0e into main Nov 29, 2024
11 of 15 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/eol-last branch November 29, 2024 20:58
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrgrain @aws-cdk-automation @sumupitchayan